- 
                Notifications
    
You must be signed in to change notification settings  - Fork 460
 
Use crddoc tool to generate CRD documentation #5565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use crddoc tool to generate CRD documentation #5565
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main    #5565   +/-   ##
=======================================
  Coverage   52.86%   52.86%           
=======================================
  Files         272      272           
  Lines       29474    29474           
=======================================
  Hits        15582    15582           
  Misses      13080    13080           
  Partials      812      812           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
| 
           I checked to see what ASO is doing, and they're using a maintained fork of the gen-crd-documentation tool. I think that's the way to go, so I'm trying to get it working.  | 
    
36afc81    to
    251e114      
    Compare
  
    | 
           /retitle Use crddoc tool to generate CRD documentation  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
| 
           LGTM label has been added. Git tree hash: 4b0c8a37f2d790c737ee3b8a1f0e95ec73ea6499 
       | 
    
| 
           /lgtm  | 
    
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nawazkh, willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Fixes a doc generation error by switching from an unmaintained community tool to a more active fork developed by our friends at ASO.
Which issue(s) this PR fixes:
Fixes #5564
Special notes for your reviewer:
TODOs:
Release note: