-
Notifications
You must be signed in to change notification settings - Fork 460
Add clusterctl upgrade tests with AKS workload clusters #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clusterctl upgrade tests with AKS workload clusters #5680
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5680 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 278 278
Lines 29610 29610
=======================================
Hits 15647 15647
Misses 13146 13146
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hunting for flakes in the new tests 🔍 /test pull-cluster-api-provider-azure-apiversion-upgrade |
anotha one /test pull-cluster-api-provider-azure-apiversion-upgrade |
c0adb83 to
0909161
Compare
|
More flake hunting now that #5560 is merged: /test pull-cluster-api-provider-azure-apiversion-upgrade |
|
/test pull-cluster-api-provider-azure-apiversion-upgrade |
|
|
/retest |
|
/lgtm /hold in case prow doesn't wait for capi-e2e test |
|
LGTM label has been added. Git tree hash: ecb25645f4cb24c14623528f27aeebdb3bc3680e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
These changes don't affect the tests in the capi-e2e job. One more run of the apiversion-upgrade job will help me sleep tonight. /test pull-cluster-api-provider-azure-apiversion-upgrade |
|
No flakes in the new tests, and I'm reasonably confident the capi-e2e failures are unrelated. /hold cancel |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds e2e tests that upgrade a CAPZ that's managing AKS workload clusters.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4361
Special notes for your reviewer:
I included some drive-by changes here in separate commits.
TODOs:
Release note: