Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 8, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds e2e tests that upgrade a CAPZ that's managing AKS workload clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4361

Special notes for your reviewer:

I included some drive-by changes here in separate commits.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2025
@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.84%. Comparing base (73e4394) to head (0909161).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5680   +/-   ##
=======================================
  Coverage   52.84%   52.84%           
=======================================
  Files         278      278           
  Lines       29610    29610           
=======================================
  Hits        15647    15647           
  Misses      13146    13146           
  Partials      817      817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 8, 2025

Hunting for flakes in the new tests 🔍

/test pull-cluster-api-provider-azure-apiversion-upgrade

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 8, 2025

Hunting for flakes in the new tests 🔍

anotha one

/test pull-cluster-api-provider-azure-apiversion-upgrade

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2025
@nojnhuh nojnhuh force-pushed the clusterctl-upgrade-aks branch from c0adb83 to 0909161 Compare June 10, 2025 16:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 10, 2025

More flake hunting now that #5560 is merged:

/test pull-cluster-api-provider-azure-apiversion-upgrade

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 10, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 10, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade

#5690

@willie-yao
Copy link
Contributor

/retest

@jackfrancis
Copy link
Contributor

/lgtm
/approve

/hold in case prow doesn't wait for capi-e2e test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ecb25645f4cb24c14623528f27aeebdb3bc3680e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-capi-e2e 0909161 link false /test pull-cluster-api-provider-azure-capi-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 10, 2025

These changes don't affect the tests in the capi-e2e job. One more run of the apiversion-upgrade job will help me sleep tonight.

/test pull-cluster-api-provider-azure-apiversion-upgrade

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 11, 2025

No flakes in the new tests, and I'm reasonably confident the capi-e2e failures are unrelated.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 72e27d0 into kubernetes-sigs:main Jun 11, 2025
24 of 25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jun 11, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Jun 11, 2025
@nojnhuh nojnhuh deleted the clusterctl-upgrade-aks branch June 11, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Test upgrades of CAPZ installations that manage AKS clusters

4 participants