Skip to content

Warning messages added for deprecation of AzureManaged API #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Warning messages added for deprecation of AzureManaged API #5699

merged 1 commit into from
Jun 17, 2025

Conversation

@alimaazamat
Copy link
Contributor

@alimaazamat alimaazamat commented Jun 12, 2025 •
edited by k8s-ci-robot
Loading

What type of PR is this?
/kind cleanup
/kind deprecation

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5697

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Warning messages added for deprecation of AzureManaged API

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jun 12, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and nojnhuh June 12, 2025 21:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2025
@alimaazamat alimaazamat changed the title Warning message added for deprecation of AzureManaged API Warning messages added for deprecation of AzureManaged API Jun 12, 2025
@alimaazamat
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.84%. Comparing base (a0a7725) to head (71412b8).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5699   +/-   ##
=======================================
  Coverage   52.84%   52.84%           
=======================================
  Files         278      278           
  Lines       29610    29610           
=======================================
  Hits        15647    15647           
  Misses      13146    13146           
  Partials      817      817

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alimaazamat
Copy link
Contributor Author

/retest

1 similar comment
@alimaazamat
Copy link
Contributor Author

/retest

@alimaazamat
Copy link
Contributor Author

/retest pull-cluster-api-provider-azure-e2e

@k8s-ci-robot
Copy link
Contributor

@alimaazamat: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-azure-apiversion-upgrade

/test pull-cluster-api-provider-azure-build

/test pull-cluster-api-provider-azure-ci-entrypoint

/test pull-cluster-api-provider-azure-e2e

/test pull-cluster-api-provider-azure-e2e-aks

/test pull-cluster-api-provider-azure-test

/test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-azure-apidiff

/test pull-cluster-api-provider-azure-apiserver-ilb

/test pull-cluster-api-provider-azure-capi-e2e

/test pull-cluster-api-provider-azure-conformance

/test pull-cluster-api-provider-azure-conformance-custom-builds

/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

/test pull-cluster-api-provider-azure-e2e-optional

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

/test pull-cluster-api-provider-azure-load-test-custom-builds

/test pull-cluster-api-provider-azure-perf-test-apiserver-availability

/test pull-cluster-api-provider-azure-windows-custom-builds

/test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-azure-apidiff

pull-cluster-api-provider-azure-build

pull-cluster-api-provider-azure-ci-entrypoint

pull-cluster-api-provider-azure-e2e

pull-cluster-api-provider-azure-e2e-aks

pull-cluster-api-provider-azure-test

pull-cluster-api-provider-azure-verify

In response to this:

/retest pull-cluster-api-provider-azure-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alimaazamat
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

mboersma
mboersma approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9469b9829eee0e769f103b0b9c9042559e6f7c48

@mboersma
Copy link
Contributor

/release-note-none
/label tide/merge-method-squash
(in case we forget to squash the commits)

@k8s-ci-robot
Copy link
Contributor

@mboersma: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation".

In response to this:

/release-note-none
/label tide/merge-method-squash
(in case we forget to squash the commits)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 13, 2025
@mboersma
Copy link
Contributor

/release-note-edit

Warning messages added for deprecation of AzureManaged API

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 13, 2025
@alimaazamat alimaazamat force-pushed the AzureManaged-warnings branch from aa5cf9d to 71412b8 Compare June 16, 2025 16:42
@alimaazamat
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

willie-yao
willie-yao approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@alimaazamat
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

@alimaazamat
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit c6c8fe0 into kubernetes-sigs:main Jun 17, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Jun 17, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jun 17, 2025
@alimaazamat alimaazamat deleted the AzureManaged-warnings branch June 17, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@mboersma mboersma

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

CAPZ Planning
Status: Done

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

Deprecation Warning Messages for AzureManaged API

4 participants

@alimaazamat @k8s-ci-robot @mboersma @willie-yao