Skip to content

Bump Go toolchain to v1.23.10 #5707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Bump Go toolchain to v1.23.10 #5707

merged 1 commit into from
Jun 20, 2025

Conversation

@mboersma
Copy link
Contributor

@mboersma mboersma commented Jun 17, 2025 •
edited
Loading

/kind cleanup

What this PR does / why we need it:

Updates the Go toolchain to v1.23.10. List of changes is here: https://github.com/golang/go/issues?q=milestone%3AGo1.23.10+label%3ACherryPickApproved

Which issue(s) this PR fixes:

Refs #5620

Special notes for your reviewer:

This issue that prevented us from upgrading to v1.23.9 was fixed and backported in this release:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2025
@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

/cherry-pick release-1.20

@k8s-infra-cherrypick-robot
Copy link

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma mboersma moved this from Todo to Needs Review in CAPZ Planning Jun 18, 2025
willie-yao
willie-yao approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ae8cb86c2a3c2cf8c42278bc0966f0e1bdc8ea3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@mboersma
Copy link
Contributor Author

/retest

2 similar comments
@nojnhuh
Copy link
Contributor

nojnhuh commented Jun 19, 2025

/retest

@willie-yao
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6b66b2d into kubernetes-sigs:main Jun 20, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jun 20, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in CAPZ Planning Jun 20, 2025
@k8s-infra-cherrypick-robot
Copy link

@mboersma: new pull request created: #5724

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 20, 2025
Merged
@mboersma mboersma deleted the bump-go-toolchain branch June 20, 2025 00:42
@mboersma mboersma mentioned this pull request Jul 28, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

5 participants

@mboersma @k8s-infra-cherrypick-robot @k8s-ci-robot @nojnhuh @willie-yao