-
Notifications
You must be signed in to change notification settings - Fork 460
Remove Windows nodes from HA e2e test #5708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 2094631411b8ea98c4a487cafb217652b1fc0063
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5708 +/- ##
=======================================
Coverage 52.84% 52.84%
=======================================
Files 278 278
Lines 29610 29610
=======================================
Hits 15647 15647
Misses 13146 13146
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cherry-pick release-1.19 This isn't going to work, is it? 😄 |
|
@mboersma: new pull request created: #5716 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.20 |
|
@mboersma: new pull request created: #5717 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
This PR removes the Windows nodes from the HA control plane test since creating Windows nodes has been flaky in general and doesn't affect the HA-ness of the control plane.
This test is where most of the failures are happening, probably because it's a required test run for every PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #5686
Special notes for your reviewer:
TODOs:
Release note: