Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 18, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR updates the four-year-old cloudbuild image we use to push images to the staging repo. This isn't fixing any real errors, but the logs get a little noisy with messages like this:

go: errors parsing go.mod:
/workspace/go.mod:3: invalid go version '1.23.2': must match format 1.23
/workspace/go.mod:5: unknown directive: toolchain

I think these are coming from the go list commands we embed in the Makefile. At least there are four of those and those messages appear in groups of four.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2025
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.84%. Comparing base (38c1db6) to head (8a0ec28).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5715   +/-   ##
=======================================
  Coverage   52.83%   52.84%           
=======================================
  Files         278      278           
  Lines       29610    29610           
=======================================
+ Hits        15645    15647    +2     
+ Misses      13148    13146    -2     
  Partials      817      817           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh nojnhuh mentioned this pull request Jun 18, 2025
4 tasks
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc4da185fcc09625840558d79a0174f96c2498ee

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@mboersma mboersma moved this from Todo to Needs Review in CAPZ Planning Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9835698 into kubernetes-sigs:main Jun 18, 2025
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jun 18, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in CAPZ Planning Jun 18, 2025
@nojnhuh nojnhuh deleted the cloudbuild-image branch June 28, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants