Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 18, 2025

What type of PR is this?
/kind flake

What this PR does / why we need it:

Manual cherry-pick of #5696:

This PR adds MachineHealthChecks which will remediate control plane nodes that fail to bootstrap in e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #5687

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 18, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 18, 2025

/assign @mboersma

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (c7dbd58) to head (fe1a707).
Report is 5 commits behind head on release-1.19.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.19    #5718   +/-   ##
=============================================
  Coverage         52.57%   52.57%           
=============================================
  Files               272      272           
  Lines             29474    29474           
=============================================
  Hits              15495    15495           
  Misses            13177    13177           
  Partials            802      802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3894db5b0b68d30dbdc8ceafed0272821e41e193

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jun 19, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 08e3d85 into kubernetes-sigs:release-1.19 Jun 19, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Jun 19, 2025
@nojnhuh nojnhuh deleted the e2e-mhc-1.19 branch June 19, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants