-
Notifications
You must be signed in to change notification settings - Fork 460
Fix DRA conformance config #5756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5756 +/- ##
=======================================
Coverage 52.81% 52.82%
=======================================
Files 279 279
Lines 29629 29629
=======================================
+ Hits 15650 15652 +2
+ Misses 13162 13160 -2
Partials 817 817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 208d79fc96382602a84c119a664d85bfe7d31d0d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold for the test to finish |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
DRA tests are running and green. /hold cancel |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The label filter we use to select DRA e2e tests to run in the conformance job seems to have gotten out of sync with upstream such that now no tests are run at all. This change updates the label filter to match the k/k
pull-kubernetes-kind-drajob which exercises the functionality that requires only the DynamicResourceAllocation feature gate.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: