Add prow apiserver ilb template that supports custom k8s images #5797
+638
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5797 +/- ##
==========================================
+ Coverage 52.94% 53.06% +0.12%
==========================================
Files 279 279
Lines 29666 29677 +11
==========================================
+ Hits 15706 15749 +43
+ Misses 13147 13112 -35
- Partials 813 816 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
willie-yao
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
willie-yao
force-pushed
the
custom-image-template
branch
from
b173fa1 to
d2da35e
Compare
willie-yao
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: db3e1f051a9400953367fab62e7a5ddbc4af450e
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a prow template that supports apiserver-ilb and allows for testing custom k8s images by setting the following env variables:
KUBE_APISERVER_IMAGE,KUBE_CONTROLLER_MANAGER_IMAGE,KUBE_SCHEDULER_IMAGE, andKUBE_PROXY_IMAGEWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: