-
Notifications
You must be signed in to change notification settings - Fork 452
WIP: Debug truncated controller logs in e2e tests #5799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-e2e-optional |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5799 +/- ##
==========================================
- Coverage 53.06% 53.06% -0.01%
==========================================
Files 279 279
Lines 29677 29677
==========================================
- Hits 15749 15747 -2
- Misses 13112 13114 +2
Partials 816 816 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/test pull-cluster-api-provider-azure-e2e-optional |
/test pull-cluster-api-provider-azure-e2e-optional |
1 similar comment
/test pull-cluster-api-provider-azure-e2e-optional |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In our e2e tests, controller logs for CAPZ, CAPI, ASO, etc. stop being collected after the first test completes for some unknown reason. Here I'm pulling ideas from kubernetes-sigs/cluster-api#4706 and kubernetes-sigs/cluster-api#7935 to see if those improve the situation for CAPZ.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: