-
Notifications
You must be signed in to change notification settings - Fork 452
Add MachineHealthCheck for control plane to private cluster e2e template #5801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-e2e-optional |
For better CI signal: /cherry-pick release-1.20 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5801 +/- ##
=======================================
Coverage 53.06% 53.06%
=======================================
Files 279 279
Lines 29677 29677
=======================================
Hits 15749 15749
Misses 13112 13112
Partials 816 816 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test pull-cluster-api-provider-azure-e2e-optional |
1 similar comment
/test pull-cluster-api-provider-azure-e2e-optional |
Testing kubernetes/test-infra#35109: /test pull-cluster-api-provider-azure-load-test-custom-builds |
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds |
1 similar comment
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds |
What type of PR is this?
/kind flake
What this PR does / why we need it:
The private cluster e2e test seems to be hitting #5687. This PR ports the fix to most of the templates in #5696 to the private cluster template.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: