-
Notifications
You must be signed in to change notification settings - Fork 460
Bump installed ASO to v2.13.0 #5832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # The ASO version here is managed by `make generate-aso-crds` | ||
| - https://github.com/Azure/azure-service-operator/releases/download/v2.13.0/azureserviceoperator_v2.13.0.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this file are entirely whitespace as a consequence of being fed through yq, with the exception of the intended bump to the version and this new comment.
| RBAC_ROOT ?= $(MANIFEST_ROOT)/rbac | ||
| ASO_CRDS_PATH := $(MANIFEST_ROOT)/aso/crds.yaml | ||
| ASO_VERSION := v2.11.0 | ||
| ASO_VERSION := $(shell go list -m -f '{{ .Version }}' github.com/Azure/azure-service-operator/v2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. Git tree hash: af19955e10cd301b3611968705d507c6523ccf04
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I don't think we need to backport this. AFAIK CAPZ isn't taking advantage of any new features from newer ASO libraries that aren't implemented in older running ASO instances. Bumping ASO in a patch release might also be disruptive. |
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5832 +/- ##
=======================================
Coverage 46.94% 46.94%
=======================================
Files 279 279
Lines 29687 29687
=======================================
Hits 13936 13936
Misses 14938 14938
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
|
/milestone v1.22 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The last two bumps to ASO in go.mod in #5517 and #5428 didn't also update the version of ASO that gets installed alongside CAPZ which we generally try to keep in sync (e.g. #5170). This PR adds a mechanism to derive the ASO version used for the manifest fed to kustomize from go.mod. This means dependabot PRs for ASO should now generally do the right thing and we only need to exercise the normal amount of care with those (checking changelogs, fixing compile failures, etc.).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: