Skip to content

Bump prior versions of CAPZ for upgrade e2e tests #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Bump prior versions of CAPZ for upgrade e2e tests #5935

merged 2 commits into from
Oct 23, 2025
+16 −16

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 22, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This PR bumps the versions of CAPZ we test upgrades from to the latest patch releases.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2025
@marosset
Copy link
Contributor

/lgtm
/hold for ci

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b421a15b2ce1c827e80eac0c4fb8606a85e1f6c

@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.59%. Comparing base (126d5fb) to head (1203d49).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
- Coverage   46.94%   44.59%   -2.36%     
==========================================
  Files         279      279              
  Lines       29688    25129    -4559     
==========================================
- Hits        13937    11206    -2731     
+ Misses      14938    13110    -1828     
  Partials      813      813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jackfrancis
jackfrancis approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@jackfrancis
Copy link
Contributor

This PR should prevent us from having to hold changes like this going forward: kubernetes/test-infra#35760

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 22, 2025

#5690

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
jackfrancis
jackfrancis approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 476fc4879107676e4c356a62089f6ca1593afb06

@mboersma mboersma moved this from Todo to In Progress in CAPZ Planning Oct 23, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 23, 2025

#5690

/retest

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 23, 2025

Upgrade tests passed!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 398697b into kubernetes-sigs:main Oct 23, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Oct 23, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in CAPZ Planning Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@marosset marosset Awaiting requested review from marosset

Assignees

@jackfrancis jackfrancis

@marosset marosset

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

4 participants

@nojnhuh @marosset @k8s-ci-robot @jackfrancis