-
Notifications
You must be signed in to change notification settings - Fork 459
[release-1.20] Fix mishandling of azure:// prefix on AzureMachine UserAssignedIdentities #5937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.20] Fix mishandling of azure:// prefix on AzureMachine UserAssignedIdentities #5937
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.20 #5937 +/- ##
=============================================
Coverage 52.80% 52.81%
=============================================
Files 279 279
Lines 29602 29602
=============================================
+ Hits 15632 15634 +2
+ Misses 13156 13154 -2
Partials 814 814 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bootstrap flake /retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 4ae8356f9ad13bc8ef96e7836e5722ffe9a6e4a7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Manual cherry-pick of #5930:
With the same caveat as #5932:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Ref #5929
Special notes for your reviewer:
TODOs:
Release note: