Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/cluster-template-machinepool-windows.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions templates/cluster-template-windows-apiserver-ilb.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions templates/cluster-template-windows.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
register-with-taints: node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to add this here since the kubelet always adds this when cloud-provider=external:

https://github.com/kubernetes/kubernetes/blob/v1.34.2/pkg/kubelet/kubelet_node_status.go#L337-L345

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not seeing this taint, then that must be a sign that the kubelet isn't starting properly.

files:
- contentFrom:
secret:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
register-with-taints: node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule
v: "2"
windows-priorityclass: "ABOVE_NORMAL_PRIORITY_CLASS"
files:
Expand Down
1 change: 1 addition & 0 deletions templates/flavors/windows/machine-deployment-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
register-with-taints: node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
files:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions templates/test/ci/cluster-template-prow-windows.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
register-with-taints: node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule
v: "2"
windows-priorityclass: "ABOVE_NORMAL_PRIORITY_CLASS"
files:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.