Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Dec 1, 2025

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

Manual cherry-pick of #5960:

Updates templates to use reference images from the CAPZ Community Gallery.

Some CI templates were still referencing Azure Marketplace images, which are deprecated and will no longer work for testing Kubernetes v1.35+.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Dec 1, 2025

/test ?

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
/test pull-cluster-api-provider-azure-build-v1beta1
/test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
/test pull-cluster-api-provider-azure-e2e-aks-v1beta1
/test pull-cluster-api-provider-azure-e2e-v1beta1
/test pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1
/test pull-cluster-api-provider-azure-test-v1beta1
/test pull-cluster-api-provider-azure-verify-v1beta1

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-azure-apidiff-v1beta1
/test pull-cluster-api-provider-azure-capi-e2e-v1beta1
/test pull-cluster-api-provider-azure-conformance-v1beta1
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1
/test pull-cluster-api-provider-azure-e2e-optional-v1beta1
/test pull-cluster-api-provider-azure-e2e-windows-v1beta1
/test pull-cluster-api-provider-azure-load-test-1k-dra-with-workload-custom-builds
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds
/test pull-cluster-api-provider-azure-load-test-dra-with-workload-custom-builds

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-azure-apidiff-v1beta1
pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
pull-cluster-api-provider-azure-build-v1beta1
pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
pull-cluster-api-provider-azure-e2e-aks-v1beta1
pull-cluster-api-provider-azure-e2e-v1beta1
pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1
pull-cluster-api-provider-azure-test-v1beta1
pull-cluster-api-provider-azure-verify-v1beta1

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Dec 1, 2025

/test pull-cluster-api-provider-azure-conformance-v1beta1
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Dec 1, 2025

/test pull-cluster-api-provider-azure-conformance-v1beta1
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1
/test pull-cluster-api-provider-azure-load-test-dra-custom-builds

/hold for those tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2025
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @nojnhuh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33866cd3280641e3872a4e757f4fbefa319405f2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.53%. Comparing base (b8f62ac) to head (2b8372e).
⚠️ Report is 8 commits behind head on release-1.20.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.20    #5987      +/-   ##
================================================
- Coverage         52.80%   51.53%   -1.28%     
================================================
  Files               279      279              
  Lines             29602    25070    -4532     
================================================
- Hits              15632    12920    -2712     
+ Misses            13156    11336    -1820     
  Partials            814      814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-load-test-dra-custom-builds 2b8372e link false /test pull-cluster-api-provider-azure-load-test-dra-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Dec 1, 2025

pull-cluster-api-provider-azure-load-test-dra-custom-builds failed because the template is new enough that it doesn't exist on the release-1.20 branch. The other two jobs have gotten to the point where the cluster is created which is what this change addresses, so I think we're in the clear.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit e2fe3c8 into kubernetes-sigs:release-1.20 Dec 1, 2025
21 of 24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Dec 1, 2025
@nojnhuh nojnhuh deleted the update-templates-1.20 branch December 1, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants