azure: support system-assigned managed identity#6152
azure: support system-assigned managed identity#6152patrickdillon wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @patrickdillon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6152 +/- ##
==========================================
- Coverage 44.43% 44.43% -0.01%
==========================================
Files 280 280
Lines 25367 25371 +4
==========================================
+ Hits 11272 11273 +1
- Misses 13283 13286 +3
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
System-assigned managed identities can be used in the same manner as user-assigned managed identities, simply by leaving the ID unset.
01cae4f to
18b0d21
Compare
|
/hold testing of this has so far been unsuccessful |
System-assigned managed identities can be used in the same manner as user-assigned managed identities, simply by leaving the ID unset.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows system-assigned managed identities as well as the currently supported user-assigned managed identity.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
One thing that's ugly about this is that it currently uses the
UserAssignedMSIidentity type. I figured I would float this simple fix to start the conversation. Happy to add a new type if that is better.TODOs:
Release note: