Skip to content

Updated Makefile to check and warn if az cli if unavailable in local#6177

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
vishalanarase:fix/issue-5291
Mar 25, 2026
Merged

Updated Makefile to check and warn if az cli if unavailable in local#6177
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
vishalanarase:fix/issue-5291

Conversation

@vishalanarase
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds a check-az-cli Makefile target that detects whether azure-cli (az) is on PATH, prints a clear warning with install instructions when it is not, and runs automatically before make tilt-up so developers are told to install Azure CLI before Tilt hits az (e.g. VNet peering with an AKS management cluster). Supports VERBOSE=1 make check-az-cli to print the resolved az path when present.
Removes the obsolete TODO in the Tiltfile now covered by the Makefile check. Updates the development guide and AGENTS.md to describe the behavior.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5291

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

make tilt-up now runs a check that warns when the Azure CLI (az) is not installed or not on PATH, with optional VERBOSE=1 on make check-az-cli to print the detected binary path.

Signed-off-by: Vishal Anarase <iamvishalanarase@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 20, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.67%. Comparing base (50f20f4) to head (2302f6d).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6177   +/-   ##
=======================================
  Coverage   43.66%   43.67%           
=======================================
  Files         289      289           
  Lines       25495    25495           
=======================================
+ Hits        11132    11134    +2     
+ Misses      13561    13559    -2     
  Partials      802      802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willie-yao
Copy link
Contributor

/assign

@vishalanarase
Copy link
Member Author

/assign

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 0985a513cf55ef5e2cee732b9d23787ecd2207ad

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2026
@k8s-ci-robot k8s-ci-robot merged commit 02c496b into kubernetes-sigs:main Mar 25, 2026
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 25, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update Makefile to check and warn if az cli if unavailable in local

4 participants