Skip to content

Requeue instead of throwing an error when onwer of kind can't be found #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Requeue instead of throwing an error when onwer of kind can't be found #417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6449b4a
Requeue instead of throwing an error when onwer of kind can't be found
vishesh92 Mar 11, 2025
61e1fb8
Add unit test
vishesh92 Mar 11, 2025
5a66366
Update controllers/utils/utils.go
vishesh92 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions controllers/utils/base_reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,9 @@ func (r *ReconcilerBase) InitFromMgr(mgr ctrl.Manager, client cloud.Client) {
func (r *ReconciliationRunner) GetParent(child client.Object, parent client.Object) CloudStackReconcilerMethod {
return func() (ctrl.Result, error) {
err := GetOwnerOfKind(r.RequestCtx, r.K8sClient, child, parent)
if err != nil && strings.Contains(err.Error(), "couldn't find owner of kind") {
return r.RequeueWithMessage(err.Error())
}
return ctrl.Result{}, err
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ func CheckAffinityGroupInProject(client *cloudstack.CloudStackClient, clusterNam

for _, affinity := range vm.Affinitygroup {
affinityIds = append(affinityIds, affinity.Id)
affinity, _, _ := client.AffinityGroup.GetAffinityGroupByID(affinity.Id, cloudstack.WithProject(project))
affinity, _, err := client.AffinityGroup.GetAffinityGroupByID(affinity.Id, cloudstack.WithProject(project))
if err != nil {
Fail("Failed to get affinity group for " + affinity.Id + " : " + err.Error())
}
Expand Down