Added e2e test for multiple network support #455
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @harikrishna-patnala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Test Results : (tid-887) |
|
Test Results : (tid-888) |
|
Test Results : (tid-889) |
|
Test Results : (tid-891) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 25.66% 25.21% -0.46%
==========================================
Files 59 72 +13
Lines 5563 6941 +1378
==========================================
+ Hits 1428 1750 +322
- Misses 3996 5022 +1026
- Partials 139 169 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test Results : (tid-890) |
|
Test Results : (tid-892) |
|
Tests were aborted. |
1 similar comment
|
Tests were aborted. |
|
Test Results : (tid-895) |
|
Test Results : (tid-896) |
vishesh92
requested review from
vishesh92 and
Copilot
and removed request for
dims
There was a problem hiding this comment.
Pull Request Overview
This PR adds an end-to-end test to verify multiple network support on CloudStack nodes.
- Introduces a new e2e spec and helper functions to create and validate a secondary network
- Adds CloudStackMachineTemplate patches and a kustomization for dual-network setups
- Updates the e2e test configuration to include the multiple-networks template
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/multiple_networks_test.go | New entry point for the multiple networks spec |
| test/e2e/multiple_networks.go | Implements MultipleNetworksSpec, cluster creation, and NIC validation |
| test/e2e/data/infrastructure-cloudstack/v1beta3/cluster-template-multiple-networks/multiple-networks.yaml | Defines dual-network machine templates |
| test/e2e/data/infrastructure-cloudstack/v1beta3/cluster-template-multiple-networks/kustomization.yaml | Registers the multiple-networks patch |
| test/e2e/config/cloudstack.yaml | Adds the new multiple-networks template to the provider config |
| test/e2e/common.go | Adds EnsureSecondaryNetworkExists and CheckIfNodesHaveTwoNICs helper functions |
Comments suppressed due to low confidence (2)
test/e2e/common.go:578
- Missing import for the CloudStack client package, causing unresolved reference to
cloudstack. Add the appropriate import (e.g.,github.com/apache/cloudstack-go/v2/cloudstack).
func EnsureSecondaryNetworkExists(client *cloudstack.CloudStackClient, input CommonSpecInput) (*cloudstack.Network, error) {
test/e2e/config/cloudstack.yaml:105
- The referenced file does not exist. Update
sourcePathto point to the kustomization directory (../data/infrastructure-cloudstack/v1beta3/cluster-template-multiple-networks/) or to the correct YAML file path.
- sourcePath: "../data/infrastructure-cloudstack/v1beta3/cluster-template-multiple-networks.yaml"
.../infrastructure-cloudstack/v1beta3/cluster-template-multiple-networks/multiple-networks.yaml
Show resolved
Hide resolved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
harikrishna-patnala
force-pushed
the
testsForMultiNicSupport
branch
from
a933165 to
14cb7cb
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harikrishna-patnala, vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Description of changes:
Added e2e test for multiple network support for the K8s nodes
Testing performed:
Ran the specific test and it has passed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.