-
Notifications
You must be signed in to change notification settings - Fork 221
Add GKE NetworkPolicy support #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,9 @@ manager_pull_policy.yaml-e | |
| # junit files | ||
| junit.*.xml | ||
|
|
||
| # asdf | ||
| .tool-versions | ||
|
|
||
| .DS_Store | ||
|
|
||
| # Tilt files. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,10 @@ type GCPManagedControlPlaneSpec struct { | |
| // This feature is disabled if this field is not specified. | ||
| // +optional | ||
| MasterAuthorizedNetworksConfig *MasterAuthorizedNetworksConfig `json:"master_authorized_networks_config,omitempty"` | ||
| // NetworkPolicy represents configuration options for NetworkPolicy feature of the GKE cluster. | ||
| // This feature is disabled if this field is not specified. | ||
| // +optional | ||
| NetworkPolicy *NetworkPolicy `json:"networkPolicy,omitempty"` | ||
| } | ||
|
|
||
| // GCPManagedControlPlaneStatus defines the observed state of GCPManagedControlPlane. | ||
|
|
@@ -142,6 +146,14 @@ type MasterAuthorizedNetworksConfigCidrBlock struct { | |
| CidrBlock string `json:"cidr_block,omitempty"` | ||
| } | ||
|
|
||
| // NetworkPolicy represents configuration options for NetworkPolicy feature of the GKE cluster. | ||
| type NetworkPolicy struct { | ||
| // The selected network policy provider. | ||
| // +kubebuilder:validation:Enum=calico | ||
| // +optional | ||
| Provider string `json:"provider,omitempty"` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If NetworkPolicy is supplied by the user should we require that they supply Provider. It feels like they should. |
||
| } | ||
|
|
||
| // GetConditions returns the control planes conditions. | ||
| func (r *GCPManagedControlPlane) GetConditions() clusterv1.Conditions { | ||
| return r.Status.Conditions | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.