Skip to content

fix: Make gcpmanagedcluster.network a required field #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Make gcpmanagedcluster.network a required field #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_gcpmanagedclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ spec:
type: object
type: array
required:
- network
- project
- region
type: object
Expand Down
1 change: 0 additions & 1 deletion exp/api/v1beta1/gcpmanagedcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ type GCPManagedClusterSpec struct {
ControlPlaneEndpoint clusterv1.APIEndpoint `json:"controlPlaneEndpoint"`

// NetworkSpec encapsulates all things related to the GCP network.
// +optional
Network infrav1.NetworkSpec `json:"network"`

// AdditionalLabels is an optional set of tags to add to GCP resources managed by the GCP provider, in addition to the
Expand Down