Skip to content

Conversation

@mloiseleur
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Related to #1331

Special notes for your reviewer:

Since we did not manage to get cloud-provider external works properly and it's not (yet) removed, I open this PR to (at least) provide a working Out Of the Box user XP when trying to start a Kubernetes 1.29+ cluster with this provider.

I'm not sure that documentation is needed, since it's already documented upstream.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Disable required feature gates for Kubernetes 1.29+

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 17, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2024
@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit a04fd60
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6710b983762ee20008b40996
😎 Deploy Preview https://deploy-preview-1333--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salasberryfin
Copy link
Contributor

Thanks @mloiseleur.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@salasberryfin
Copy link
Contributor

/assign @richardcase

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@cpanato
Copy link
Member

cpanato commented Oct 25, 2024

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot

@cpanato: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 5938bd1 into kubernetes-sigs:main Oct 25, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 25, 2024
@k8s-infra-cherrypick-robot

@cpanato: new pull request created: #1346

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants