-
Notifications
You must be signed in to change notification settings - Fork 220
chore: add clusterclass sample template #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add clusterclass sample template #1351
Conversation
Signed-off-by: Carlos Salas <[email protected]>
|
@salasberryfin: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/kind feature |
cpanato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add this in the e2e tests?
|
Hi @cpanato. This should already be covered in E2E, as templates are taken from |
Actually not, that holds all configurations but we need to hook that in the tests need to add here https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/test/e2e/config/gcp-ci.yaml#L54-L75 and then add a test cases adding the flavor like https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/test/e2e/e2e_test.go#L186-L208 |
|
Thanks for clarifying! I think we can keep this as-is and I'll open a separate PR to cover this in E2E, what do you think? |
|
sgtm, thank you so much! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature
What this PR does / why we need it:
Add
ClusterClassandTopologycluster templates based on existing E2E infrastructure files. These files will be referenced in the book so users can get started with cluster classes viaclusterctl generate, similar to the existing documentation on how to create a GKE cluster.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
A follow up to this PR will update the book and add references to these new templates.
TODOs:
Release note: