Skip to content

Conversation

@salasberryfin
Copy link
Contributor

@salasberryfin salasberryfin commented Nov 4, 2024

/kind feature

What this PR does / why we need it:

Add ClusterClass and Topology cluster templates based on existing E2E infrastructure files. These files will be referenced in the book so users can get started with cluster classes via clusterctl generate, similar to the existing documentation on how to create a GKE cluster.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

A follow up to this PR will update the book and add references to these new templates.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

@salasberryfin: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore

What this PR does / why we need it:

Add ClusterClass and Topology cluster templates based on existing E2E infrastructure files. These files will be referenced in the book so users can get started with cluster classes via clusterctl generate, similar to the existing documentation on how to create a GKE cluster.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

A follow up to this PR will update the book and add references to these new templates.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2024
@netlify
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit a05e175
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/672902b22bdad100086a08c5
😎 Deploy Preview https://deploy-preview-1351--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salasberryfin
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 4, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this in the e2e tests?

@salasberryfin
Copy link
Contributor Author

Hi @cpanato. This should already be covered in E2E, as templates are taken from ./test/e2e/data/ https://github.com/kubernetes-sigs/cluster-api-provider-gcp/tree/main/test/e2e/data/infrastructure-gcp. Is that correct?

@cpanato
Copy link
Member

cpanato commented Nov 5, 2024

Hi @cpanato. This should already be covered in E2E, as templates are taken from ./test/e2e/data/ https://github.com/kubernetes-sigs/cluster-api-provider-gcp/tree/main/test/e2e/data/infrastructure-gcp. Is that correct?

Actually not, that holds all configurations but we need to hook that in the tests

need to add here https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/test/e2e/config/gcp-ci.yaml#L54-L75

and then add a test cases adding the flavor like https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/test/e2e/e2e_test.go#L186-L208

@salasberryfin
Copy link
Contributor Author

Thanks for clarifying! I think we can keep this as-is and I'll open a separate PR to cover this in E2E, what do you think?

@cpanato
Copy link
Member

cpanato commented Nov 5, 2024

sgtm, thank you so much!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 902e324 into kubernetes-sigs:main Nov 5, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants