-
Notifications
You must be signed in to change notification settings - Fork 222
feat: align GCPManagedControlPlane with CAPI >=v1.9 #1434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align GCPManagedControlPlane with CAPI >=v1.9 #1434
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bf2c4da to
153f13f
Compare
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @salasberryfin
Thanks a lot for working on implementing this!
Mostly LGTM, left a couple of things we need to change though.
|
@salasberryfin Also we will likely need to add an cc. @richardcase |
|
@salasberryfin also we might need to silence the linter for errors like : |
richardcase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @salasberryfin 🎉
Just a couple of minor comments.
|
Thanks for the reviews @damdo @richardcase. Sorry I couldn't address your comments before, I'll be doing so today! |
|
No worries, thanks @salasberryfin |
ec845dc to
80a52a3
Compare
|
I think the latest commit addresses all of the comments @damdo @richardcase. |
|
@salasberryfin there are a few lints to tackle, thanks for working on this |
80a52a3 to
d5880ec
Compare
|
Thanks @cpanato. The exclude rule I added covered some of the cases where the linter found errors but missed some of them. Should be fixed now. |
| ControlPlaneVersion: &vV1_27_1, | ||
| EnableAutopilot: true, | ||
| ClusterName: "cluster1_autopilot", | ||
| Version: &vV1_27_1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be this updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this in a separate PR, if that's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
|
Also added the |
alexander-demicev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cpanato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev, cpanato, salasberryfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salasberryfin Mostly LGTM, I left one blocking question though. LMK thanks!
d5880ec to
7ec8133
Compare
7ec8133 to
744baff
Compare
|
Thanks for the reviews. The webhook now returns a warning if only |
cda1f3c to
bb361dd
Compare
Signed-off-by: Carlos Salas <[email protected]>
bb361dd to
af6413d
Compare
|
Hm looks like the E2Es failed https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-gcp/1434/pull-cluster-api-provider-gcp-e2e-test/1897214121795915776 Let's retest for good measure in case it is a flake, otherwise we might need to look into it. /retest |
|
Thanks @damdo, looks like it was a flake. |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Great work @salasberryfin 🥇 |
/kind bug
What this PR does / why we need it:
To align
GCPManagedControlPlanespecification and status with CAPI >=v1.9 we need to introduce new control plane version fields and set existing ones for deprecation in coming releases. The list of changes, as agreed on Slack (thanks @damdo @richardcase @cpanato):Versionfields inGCPManagedControlPlaneSpecandGCPManagedControlPlaneStatusas per the updated CAPI contract for control planes.ControlPlaneVersionandCurrentVersionas deprecated with a message saying to useVersioninstead.VersionandControlPlaneVersion.Version.Which issue(s) this PR fixes:
Fixes #1433
Special notes for your reviewer:
In the future, as the deprecated field is ultimately removed, we can add a conversion from
ControlPlaneVersiontoVersion.TODOs:
Release note: