Skip to content

Conversation

@justinsb
Copy link
Contributor

@justinsb justinsb commented Aug 29, 2025

Newer go versions flag this (non-constant used as format message). As with #1516 we may want to cherry-pick (?), and it makes #1509 smaller

chore: fix go vet errors around conditions.MarkFalse

(Technically the messages do change, and I could replace it with a "%s" or "%v" if we want the same messages. I think this is clearer and the message is not part of our contract, but I'm happy to switch to %s if desired)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 29, 2025
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit eca904c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68b17d9698a98d00089ac563
😎 Deploy Preview https://deploy-preview-1517--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from damdo and dims August 29, 2025 10:14
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 29, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
To give a chance to Carloses to review

/assign @cpanato @salasberryfin

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@salasberryfin
Copy link
Contributor

Thanks!

/lgtm too.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2025
@salasberryfin
Copy link
Contributor

I think any help with reducing the size of #1509 is nice, so let's cherry-pick this one too.

/cherrypick release-1.10

@k8s-infra-cherrypick-robot

@salasberryfin: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

I think any help with reducing the size of #1509 is nice, so let's cherry-pick this one too.

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member

damdo commented Aug 31, 2025

/test pull-cluster-api-provider-gcp-apidiff pull-cluster-api-provider-gcp-build

@k8s-ci-robot k8s-ci-robot merged commit bf2b788 into kubernetes-sigs:main Aug 31, 2025
24 checks passed
@k8s-infra-cherrypick-robot

@salasberryfin: new pull request created: #1521

In response to this:

I think any help with reducing the size of #1509 is nice, so let's cherry-pick this one too.

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants