-
Couldn't load subscription status.
- Fork 220
chore: fix go vet errors around conditions.MarkFalse #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix go vet errors around conditions.MarkFalse #1517
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thanks! /lgtm too. /unhold |
|
I think any help with reducing the size of #1509 is nice, so let's cherry-pick this one too. /cherrypick release-1.10 |
|
@salasberryfin: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-gcp-apidiff pull-cluster-api-provider-gcp-build |
|
@salasberryfin: new pull request created: #1521 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Newer go versions flag this (non-constant used as format message). As with #1516 we may want to cherry-pick (?), and it makes #1509 smaller
(Technically the messages do change, and I could replace it with a "%s" or "%v" if we want the same messages. I think this is clearer and the message is not part of our contract, but I'm happy to switch to %s if desired)