Skip to content

templates: don't pass cloud-provider to kube-apiserver #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2025
+0 −21
Merged

templates: don't pass cloud-provider to kube-apiserver #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions templates/cluster-template-clusterclass.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: gce
controllerManager:
extraArgs:
cloud-provider: gce
Expand Down
3 changes: 0 additions & 3 deletions templates/cluster-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: gce
feature-gates: "DisableCloudProviders=false,DisableKubeletCloudCredentialProviders=false"
controllerManager:
extraArgs:
cloud-provider: gce
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-ci-with-creds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-ci-with-internal-lb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-kcp-remediation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-md-remediation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-prow-ci-version.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/cluster-template-upgrades.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down
2 changes: 0 additions & 2 deletions test/e2e/data/infrastructure-gcp/clusterclass-quick-start.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ spec:
clusterConfiguration:
apiServer:
timeoutForControlPlane: 20m
extraArgs:
cloud-provider: external
controllerManager:
extraArgs:
cloud-provider: external
Expand Down