Add an e2e test for only creating an internal load balancer #1536
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bochengchu: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bochengchu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @bochengchu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| port: 6443 | ||
| loadBalancer: | ||
| loadBalancerType: InternalExternal | ||
| loadBalancerType: Internal |
There was a problem hiding this comment.
Ah I see - our existing "internal" test was actually internal & external, and so we're adding a test for the existing test case. SGTM
|
IIUC we do expect this to fail until we have #1533 , but yes will be great to see that failure! /ok-to-test |
k8s-ci-robot
added
ok-to-test
|
(Not giving LGTM/approve because we do expect this to fail, at least AIUI :-) ) |
|
This should pass because it only create 1 control node. Just realized I need to let the management cluster to be in the same private network... |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@justinsb This is ready for review. (And expected to pass, since there is only 1 control plane node.) |
|
/retest |
|
@bochengchu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
It seems the job doesn't have permissions to upload the image to GCR. Unlike kind cluster where we directly load the image to it, GKE clusters have to retrieve the image from some registry. Not sure how to update the permission though. |
3 participants
What type of PR is this?
/kind other
What this PR does / why we need it:
Currently we only have e2e tests for
loadBalancerTypeExternalandExternalInternal.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
Release note:
None