Skip to content

chore: make apidiff test more robust and informative #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

chore: make apidiff test more robust and informative #1542

merged 1 commit into from
Oct 14, 2025
+8 −3

Conversation

@justinsb
Copy link
Contributor

@justinsb justinsb commented Oct 13, 2025 •
edited
Loading

  • Use exec so that if the prow job is killed, the script is killed too
  • Print full apidiff output in both success and failure cases

NONE

@justinsb
chore: make apidiff test more robust and informative
9ef81b0 
* Use exec so that if the prow job is killed, the script is killed too
* Print full apidiff output in both success and failure cases
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2025
@k8s-ci-robot k8s-ci-robot requested a review from cpanato October 13, 2025 15:10
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@netlify
Copy link

netlify bot commented Oct 13, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 9ef81b0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68ed1670777b190008c0b883
😎 Deploy Preview https://deploy-preview-1542--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 13, 2025
@justinsb
Copy link
Contributor Author

justinsb commented Oct 13, 2025

I'm slightly at a loss as to why sometimes apidiff hangs for 50+ hours, I'm guessing the prow job is OOM killed or something like that.

@justinsb
Copy link
Contributor Author

justinsb commented Oct 13, 2025

Confirmed an OOM kill in the prow description for the test:

Terminated (OOMKilled - Activated service account credentials for: [[email protected]] + WRAPPED_COMMAND_PID=28 + wait 28 + ./scripts/ci-apidiff.sh (unset) (unset) APIDIFF_OLD_COMMIT="521ba6f23d3accf27d3a0cfa0fbf00c33921ff34" hack/verify-apidiff *** Running go-apidiff *** go: downloading github.com/joelanford/go-apidiff v0.8.3 go: downloading github.com/spf13/cobra v1.9.1 go: downloading github.com/go-git/go-billy/v5 v5.6.2 go: downloading golang.org/x/sys v0.33.0 go: downloading golang.org/x/tools v0.33.0 go: downloading github.com/go-git/go-git/v5 v5.16.0 go: downloading golang.org/x/exp v0.0.0-20250506013437-ce4c2cf36ca6 go: downloading github.com/spf13/pflag v1.0.6 go: downloading github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 go: downloading github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 go: downloading github.com/ProtonMail/go-crypto v1.2.0 go: downloading dario.cat/mergo v1.0.2 go: downloading github.com/cyphar/filepath-securejoin v0.4.1 go: downloading github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 go: downloading github.com/pjbgf/sha1cd v0.3.2 go: downloading github.com/emirpasic/gods v1.18.1 go: downloading github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 go: downloading github.com/kevinburke/ssh_config v1.2.0 go: downloading github.com/skeema/knownhosts v1.3.1 go: downloading github.com/xanzy/ssh-agent v0.3.3 go: downloading golang.org/x/crypto v0.38.0 go: downloading golang.org/x/net v0.40.0 go: downloading gopkg.in/warnings.v0 v0.1.2 go: downloading github.com/cloudflare/circl v1.6.1 go: downloading golang.org/x/sync v0.14.0 go: downloading golang.org/x/mod v0.24.0 ) at 2025-10-06 16:34:58 +0000 UTC with exit code 137

@justinsb
Copy link
Contributor Author

justinsb commented Oct 13, 2025

Also raising memory in kubernetes/test-infra#35686 to mirror apidiff CAPA jobs

@justinsb justinsb mentioned this pull request Oct 13, 2025
Open
salasberryfin
salasberryfin reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinsb.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 20859ca into kubernetes-sigs:main Oct 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salasberryfin salasberryfin salasberryfin left review comments

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@salasberryfin salasberryfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinsb @k8s-ci-robot @salasberryfin