Skip to content

chore: make apidiff test more robust and informative #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

chore: make apidiff test more robust and informative #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions hack/verify-apidiff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,14 @@ apidiffs=$(go run github.com/joelanford/[email protected] ${APIDIFF_OLD_COMMIT}
filtered=$(echo "$apidiffs" | grep -E 'cluster-api-provider-gcp/(api/|exp/api/)' || true)

if [[ -n "$filtered" ]]; then
echo "API differences found in api/ or exp/api/:"
echo "API differences found in api/ or exp/api/ packages."
echo ""
echo "Full set of differences found by go-apidiff:"
echo "$apidiffs"
exit 1
else
echo "No differences found in api/ or exp/api/ packages"
echo "No differences found in api/ or exp/api/ packages."
echo ""
echo "Full set of differences found by go-apidiff:"
echo "$apidiffs"
fi
2 changes: 1 addition & 1 deletion scripts/ci-apidiff.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/..

cd "${REPO_ROOT}"

APIDIFF_OLD_COMMIT="${PULL_BASE_SHA}" make apidiff
APIDIFF_OLD_COMMIT="${PULL_BASE_SHA}" exec make apidiff