-
Notifications
You must be signed in to change notification settings - Fork 93
Add UT for ReconcileVPCSecurityGroups function #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Welcome @arshadd-b! |
|
Hi @arshadd-b. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/easycla |
|
/ok-to-test |
9816d30 to
df64bf3
Compare
d392335 to
f99fb44
Compare
|
@arshadd-b Please update |
|
/cc @dharaneeshvrd |
f99fb44 to
d69312f
Compare
d69312f to
52f5107
Compare
de38f06 to
29d0981
Compare
250243c to
ee6f65a
Compare
ee6f65a to
e872ae4
Compare
|
@arshadd-b could you please rebase the PR. |
e872ae4 to
d8e7d54
Compare
d8e7d54 to
6af8da9
Compare
6af8da9 to
bf3c1d2
Compare
bf3c1d2 to
4764898
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Thanks @arshadd-b and @dharaneeshvrd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arshadd-b, dharaneeshvrd, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add UTs for ReconcileVPCSecurityGroups function and fixes minor bug found during writing UTs
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: