Skip to content

Conversation

@Karthik-K-N
Copy link
Contributor

@Karthik-K-N Karthik-K-N commented Jul 8, 2025

What this PR does / why we need it:

Since the flag is not supported, setting this flag in v1.33 leads to apiserver not starting as unknown flag error.

K8s reference: kubernetes/kubernetes#130162

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # part of #2416

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Remove apiserver cloud-provider: external flag as its removed in k8s v1.33

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jul 8, 2025
@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit d641283
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/686d1960846dcc0008fd4367
😎 Deploy Preview https://deploy-preview-2415.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2025
@Karthik-K-N
Copy link
Contributor Author

/hold for pending tasks in parent issue

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@Karthik-K-N
Copy link
Contributor Author

/cc @arshadd-b Please take a look.

Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for pending tasks in parent issue

@Karthik-K-N, this can be merged right and the remaining tasks can be taken up in a new PR?

or would this be a breaking change with v1.32 which are the current CI images?

@Karthik-K-N
Copy link
Contributor Author

/hold for pending tasks in parent issue

@Karthik-K-N, this can be merged right and the remaining tasks can be taken up in a new PR?

or would this be a breaking change with v1.32 which are the current CI images?

I think once the 1.33 image is imported into CI, we can merge this. What do you think?

@Amulyam24
Copy link
Contributor

I think once the 1.33 image is imported into CI, we can merge this. What do you think?

sure, I will upload the new image in the CI workspaces and update here.

@Amulyam24
Copy link
Contributor

Image imported to the CI workspaces and PR to update CI is up - #2435

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2025
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Karthik-K-N, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit e1321d2 into kubernetes-sigs:main Jul 21, 2025
14 checks passed
arshadd-b pushed a commit to arshadd-b/cluster-api-provider-ibmcloud that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants