-
Notifications
You must be signed in to change notification settings - Fork 93
🌱 Remove external cloud-provider flag from apiserver as its removed in k8s v1.33 #2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove external cloud-provider flag from apiserver as its removed in k8s v1.33 #2415
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/hold for pending tasks in parent issue |
|
/cc @arshadd-b Please take a look. |
Amulyam24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for pending tasks in parent issue
@Karthik-K-N, this can be merged right and the remaining tasks can be taken up in a new PR?
or would this be a breaking change with v1.32 which are the current CI images?
I think once the 1.33 image is imported into CI, we can merge this. What do you think? |
sure, I will upload the new image in the CI workspaces and update here. |
|
Image imported to the CI workspaces and PR to update CI is up - #2435 /unhold |
Prajyot-Parab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Since the flag is not supported, setting this flag in v1.33 leads to apiserver not starting as unknown flag error.
K8s reference: kubernetes/kubernetes#130162
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # part of #2416
Special notes for your reviewer:
/area provider/ibmcloud
Release note: