Skip to content

🌱(deps): Bump the all-go-mod-patch-and-minor group across 2 directories with 3 updates #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

🌱(deps): Bump the all-go-mod-patch-and-minor group across 2 directories with 3 updates #2493

merged 1 commit into from
Mar 24, 2025
+24 −24

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 24, 2025

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: github.com/onsi/ginkgo/v2, github.com/onsi/gomega and sigs.k8s.io/controller-runtime.
Bumps the all-go-mod-patch-and-minor group with 3 updates in the /hack/tools directory: github.com/onsi/ginkgo/v2, github.com/onsi/gomega and sigs.k8s.io/controller-runtime.

Updates github.com/onsi/ginkgo/v2 from 2.23.0 to 2.23.3

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.23.3

2.23.3

Fixes

  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

v2.23.2

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.23.3

Fixes

  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

Commits
  • 04a9a74 v2.23.3
  • cfcc1a5 allow - as a standalone argument
  • feaf292 Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()
  • 88e2282 ignore exit code for symbol test on linux
  • 979c969 v2.23.2
  • 976a5c0 strip out symbols when running ginkgo
  • 99e2fe2 v2.23.1
  • a0e52ff make it clearer that you need to pass a filename to the various profile flags...
  • b799d8d emit an error and exit if the ginkgo invocation includes flags after position...
  • a565d1f Fix typo in documentation: DescribeHandleSubtree -> DescribeTableSubtree
  • Additional commits viewable in compare view

Updates github.com/onsi/gomega from 1.36.2 to 1.36.3

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.36.3

1.36.3

Maintenance

  • bump all the things [adb8b49]
  • chore: replace interface{} with any [7613216]
  • Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822) [9fe5259]
  • remove spurious "toolchain" from go.mod (#819) [a0e85b9]
  • Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823) [604a8b1]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772) [36fbc84]
  • Bump github-pages from 231 to 232 in /docs (#778) [ced70d7]
  • Bump rexml from 3.2.6 to 3.3.9 in /docs (#788) [c8b4a07]
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812) [06431b9]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#800) [b55a92d]
  • Fix typos (#813) [a1d518b]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.36.3

Maintenance

  • bump all the things [adb8b49]
  • chore: replace interface{} with any [7613216]
  • Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822) [9fe5259]
  • remove spurious "toolchain" from go.mod (#819) [a0e85b9]
  • Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823) [604a8b1]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772) [36fbc84]
  • Bump github-pages from 231 to 232 in /docs (#778) [ced70d7]
  • Bump rexml from 3.2.6 to 3.3.9 in /docs (#788) [c8b4a07]
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812) [06431b9]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#800) [b55a92d]
  • Fix typos (#813) [a1d518b]
Commits
  • 2251143 v1.36.3
  • adb8b49 bump all the things
  • 7613216 chore: replace interface{} with any
  • 9fe5259 Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822)
  • a0e85b9 remove spurious "toolchain" from go.mod (#819)
  • 604a8b1 Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823)
  • 36fbc84 Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772)
  • ced70d7 Bump github-pages from 231 to 232 in /docs (#778)
  • c8b4a07 Bump rexml from 3.2.6 to 3.3.9 in /docs (#788)
  • 06431b9 Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812)
  • Additional commits viewable in compare view

Updates sigs.k8s.io/controller-runtime from 0.20.3 to 0.20.4

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.20.4

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.20.3...v0.20.4

Commits
  • 0f7927c Merge pull request #3179 from alvaroaleman/lowpdefault
  • 9951869 🌱 TypedRequestForOwner: Decrease priority when unchanged
  • c7d5d83 Fix godoc of TypedEventHandler
  • 2062f3a 🌱 Remove redundant WithLowPriorityWhenUnchanged in builder
  • 2af3164 🌱 Followups to default low priority in mappers
  • 29debb1 🌱 Handlers: Use low priority when object is unchanged and priority q
  • 5355658 🐛Implement priorityqueue as default on handlers if using priorityqueue interf...
  • 3156ace Merge pull request #3175 from k8s-infra-cherrypick-robot/cherry-pick-3166-to-...
  • 4ae5f39 add version.version to tools/setup-envtest to show installed version
  • 833f208 Merge pull request #3173 from k8s-infra-cherrypick-robot/cherry-pick-3167-to-...
  • Additional commits viewable in compare view

Updates github.com/onsi/ginkgo/v2 from 2.23.0 to 2.23.3

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.23.3

2.23.3

Fixes

  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

v2.23.2

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

v2.23.1

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.23.3

Fixes

  • allow - as a standalone argument [cfcc1a5]
  • Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context() [feaf292]
  • ignore exit code for symbol test on linux [88e2282]

2.23.2

🎉🎉🎉

At long last, some long-standing performance gaps between ginkgo and go test have been resolved!

Ginkgo operates by running go test -c to generate test binaries, and then running those binaries. It turns out that the compilation step of go test -c is slower than go test's compilation step because go test strips out debug symbols (ldflags=-w) whereas go test -c does not.

Ginkgo now passes the appropriate ldflags to go test -c when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and when ginkgo build is called explicitly.

This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.

2.23.1

🚨 For users on MacOS 🚨

A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.

Fixes

Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:

  • make it clearer that you need to pass a filename to the various profile flags, not an absolute directory [a0e52ff]
  • emit an error and exit if the ginkgo invocation includes flags after positional arguments [b799d8d]

This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.

Commits
  • 04a9a74 v2.23.3
  • cfcc1a5 allow - as a standalone argument
  • feaf292 Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()
  • 88e2282 ignore exit code for symbol test on linux
  • 979c969 v2.23.2
  • 976a5c0 strip out symbols when running ginkgo
  • 99e2fe2 v2.23.1
  • a0e52ff make it clearer that you need to pass a filename to the various profile flags...
  • b799d8d emit an error and exit if the ginkgo invocation includes flags after position...
  • a565d1f Fix typo in documentation: DescribeHandleSubtree -> DescribeTableSubtree
  • Additional commits viewable in compare view

Updates github.com/onsi/gomega from 1.36.2 to 1.36.3

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.36.3

1.36.3

Maintenance

  • bump all the things [adb8b49]
  • chore: replace interface{} with any [7613216]
  • Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822) [9fe5259]
  • remove spurious "toolchain" from go.mod (#819) [a0e85b9]
  • Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823) [604a8b1]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772) [36fbc84]
  • Bump github-pages from 231 to 232 in /docs (#778) [ced70d7]
  • Bump rexml from 3.2.6 to 3.3.9 in /docs (#788) [c8b4a07]
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812) [06431b9]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#800) [b55a92d]
  • Fix typos (#813) [a1d518b]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.36.3

Maintenance

  • bump all the things [adb8b49]
  • chore: replace interface{} with any [7613216]
  • Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822) [9fe5259]
  • remove spurious "toolchain" from go.mod (#819) [a0e85b9]
  • Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823) [604a8b1]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772) [36fbc84]
  • Bump github-pages from 231 to 232 in /docs (#778) [ced70d7]
  • Bump rexml from 3.2.6 to 3.3.9 in /docs (#788) [c8b4a07]
  • Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812) [06431b9]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#800) [b55a92d]
  • Fix typos (#813) [a1d518b]
Commits
  • 2251143 v1.36.3
  • adb8b49 bump all the things
  • 7613216 chore: replace interface{} with any
  • 9fe5259 Bump google.golang.org/protobuf from 1.36.1 to 1.36.5 (#822)
  • a0e85b9 remove spurious "toolchain" from go.mod (#819)
  • 604a8b1 Bump golang.org/x/net from 0.33.0 to 0.35.0 (#823)
  • 36fbc84 Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#772)
  • ced70d7 Bump github-pages from 231 to 232 in /docs (#778)
  • c8b4a07 Bump rexml from 3.2.6 to 3.3.9 in /docs (#788)
  • 06431b9 Bump github.com/onsi/ginkgo/v2 from 2.22.1 to 2.22.2 (#812)
  • Additional commits viewable in compare view

Updates sigs.k8s.io/controller-runtime from 0.20.3 to 0.20.4

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.20.4

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.20.3...v0.20.4

Commits
  • 0f7927c Merge pull request #3179 from alvaroaleman/lowpdefault
  • 9951869 🌱 TypedRequestForOwner: Decrease priority when unchanged
  • c7d5d83 Fix godoc of TypedEventHandler
  • 2062f3a 🌱 Remove redundant WithLowPriorityWhenUnchanged in builder
  • 2af3164 🌱 Followups to default low priority in mappers
  • 29debb1 🌱 Handlers: Use low priority when object is unchanged and priority q
  • 5355658 🐛Implement priorityqueue as default on handlers if using priorityqueue interf...
  • 3156ace Merge pull request #3175 from k8s-infra-cherrypick-robot/cherry-pick-3166-to-...
  • 4ae5f39 add version.version to tools/setup-envtest to show installed version
  • 833f208 Merge pull request #3173 from k8s-infra-cherrypick-robot/cherry-pick-3167-to-...
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot
🌱(deps): Bump the all-go-mod-patch-and-minor group across 2 directori…
a73d314 
…es with 3 updates

Bumps the all-go-mod-patch-and-minor group with 3 updates in the / directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo), [github.com/onsi/gomega](https://github.com/onsi/gomega) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).
Bumps the all-go-mod-patch-and-minor group with 3 updates in the /hack/tools directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo), [github.com/onsi/gomega](https://github.com/onsi/gomega) and [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `github.com/onsi/ginkgo/v2` from 2.23.0 to 2.23.3
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.23.0...v2.23.3)

Updates `github.com/onsi/gomega` from 1.36.2 to 1.36.3
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.36.2...v1.36.3)

Updates `sigs.k8s.io/controller-runtime` from 0.20.3 to 0.20.4
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.20.3...v0.20.4)

Updates `github.com/onsi/ginkgo/v2` from 2.23.0 to 2.23.3
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.23.0...v2.23.3)

Updates `github.com/onsi/gomega` from 1.36.2 to 1.36.3
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.36.2...v1.36.3)

Updates `sigs.k8s.io/controller-runtime` from 0.20.3 to 0.20.4
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.20.3...v0.20.4)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: github.com/onsi/gomega
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: indirect
  update-type: version-update:semver-patch
  dependency-group: all-go-mod-patch-and-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 24, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2025
@netlify
Copy link

netlify bot commented Mar 24, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit a73d314
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67e1b91494d07500080c97d2
😎 Deploy Preview https://deploy-preview-2493--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor

EmilienM commented Mar 24, 2025

/lgtm
/approve
/hold for ci

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@EmilienM
Copy link
Contributor

EmilienM commented Mar 24, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9a0502e into main Mar 24, 2025
10 checks passed
@k8s-ci-robot k8s-ci-robot deleted the dependabot/go_modules/main/all-go-mod-patch-and-minor-b0b967e823 branch March 24, 2025 23:46
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k8s-ci-robot @EmilienM