🌱 Don't run golanci-lint update on PRs

[lentzi90]

What this PR does / why we need it:

The workflow is failing in #2647 because the base is not set. This is an attempt to fix that.
However, creating a PR from a workflow triggered by a PR requires more privileges than the normal token has. I suggest we don't run this workflow on PRs at all, rather than giving it more permissions and a custom token.
We can still manually trigger it to run and select on which branch it should run.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	b10b418
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68a8110ee16dda00088be1d9
😎 Deploy Preview	https://deploy-preview-2659--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[lentzi90]

/hold
There is something else wrong with this workflow also. I think the reason it doesn't work on the PR is because it starts from the merge commit (not on a branch). This is not an issue in the periodic job though, but it still fails to create PRs.

[lentzi90]

Ok now it is at least trying to create the PR! The remaining issue is that the default token doesn't have permission to create PRs when the action is triggered from a PR/push. I think that is a sane policy that we should not tamper with. Perhaps we can do some kind of dry-run on PRs 🤔

[lentzi90]

I have not found any clever way to dry-run this so removing the PR trigger. We can still trigger the workflow manually on specific branches as a way of testing it.
/hold cancel

[EmilienM]

/lgtm
/approve

Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [EmilienM]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/retest