Skip to content

🌱 Remove mdbooth as a maintainer #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

🌱 Remove mdbooth as a maintainer #2727

merged 1 commit into from
Sep 24, 2025

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Sep 22, 2025

No description provided.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 22, 2025

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@netlify
Copy link

netlify bot commented Sep 22, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 609b4db
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68d2556966cff1000891271c
😎 Deploy Preview https://deploy-preview-2727--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2025
@tobiasgiese
Copy link
Member

tobiasgiese commented Sep 22, 2025 •
edited
Loading

Just FYI, all the other emeritus maintainers are in the OWNERS file, see https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/OWNERS#L11-L23.

Edit: The correct key in the OWNERS file is emeritus_approvers, see https://github.com/kubernetes-sigs/maintainers/blob/main/pkg/utils/data_utils.go#L32

@lentzi90
Copy link
Contributor

lentzi90 commented Sep 22, 2025

Oh good catch @tobiasgiese !

This was referenced Sep 22, 2025
Merged
Merged
Merged
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 23, 2025

There are empty aliases in OWNER_ALIASES, cleanup is advised.

@mdbooth
Copy link
Contributor Author

mdbooth commented Sep 23, 2025

@lentzi90 I've pushed this branch to the wrong repo 🤦 This is annoying because it has automatically gained branch protections. I discovered this when I tried to force push a fix. I decided it was slightly less annoying to continue with this one that create a new PR in the correct repo, but just highlighting this in case the branch is difficult to delete after it merges.

lentzi90
lentzi90 reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see you go 😢
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
k8s-ci-robot pushed a commit to kubernetes/org that referenced this pull request Sep 23, 2025
@mdbooth
Sync CAPO maintainers
df69e65 
See:
kubernetes-sigs/cluster-api-provider-openstack#2727

Also cleanup of other emeritus approvers.
@EmilienM
Copy link
Contributor

EmilienM commented Sep 24, 2025

/lgtm
/approve

😭

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 77c09c2 into main Sep 24, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Sep 24, 2025
@lentzi90 lentzi90 deleted the remove-mdbooth branch October 3, 2025 07:31
@lentzi90
Copy link
Contributor

lentzi90 commented Oct 7, 2025

/cherry-pick release-0.13 release-0.12 release-0.11

@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Oct 7, 2025

@lentzi90: new pull request created: #2759

In response to this:

/cherry-pick release-0.13 release-0.12 release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mdbooth @k8s-ci-robot @tobiasgiese @lentzi90 @EmilienM @k8s-infra-cherrypick-robot