Skip to content

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Oct 7, 2025

What this PR does / why we need it:

This commit changes how to run and build codegen. Instead of using a script inside the openapi-gen package, we now build and call the binary directly. This avoids issues where the upstream package is incompatible with the go version we use (as seen currently on release-0.12).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Related to (but does not fix) #2742
We need to do a manual backport of this to fix that issue.

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

This commit changes how to run and build codegen. Instead of using a script inside the
openapi-gen package, we now build and call the binary directly. This avoids issues where the
upstream package is incompatible with the go version we use (as seen currently on release-0.12).

Signed-off-by: Lennart Jern <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
Copy link

netlify bot commented Oct 7, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 56364aa
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68e4eeb5c4dd050008a9fecc
😎 Deploy Preview https://deploy-preview-2761--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 8, 2025

/hold cancel
/cc @smoshiur1237 @adilGhaffarDev
Can you check if this makes sense?
The reason I want this merged is that the current way of doing this has broken tests on release-0.12 (#2742). Main is unaffected at this time, but it would not make sense to do code generation differently on a release branch than on main. So I want to refactor here on main and then backport (see #2762) to fix the release branch.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
@lentzi90 lentzi90 mentioned this pull request Oct 8, 2025
3 tasks
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes more useful and it is not dependent on the incompatible go version.
Thanks for this addition
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@adilGhaffarDev
Copy link

LGTM

@lentzi90
Copy link
Contributor Author

lentzi90 commented Oct 8, 2025

Thank you both!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc0b630 into kubernetes-sigs:main Oct 8, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 8, 2025
@lentzi90 lentzi90 deleted the lentzi90/codegen branch October 8, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants