Skip to content

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

We are currently seeing errors like the following when kustomize is bumped on release-0.12:

 make -C hack/tools bin/openapi-gen
make[1]: Entering directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/hack/tools'
go build -tags=tools -o bin/openapi-gen k8s.io/kube-openapi/cmd/openapi-gen
go: downloading k8s.io/gengo/v2 v2.0.0-20240228010128-51d4e06bde70
go: downloading k8s.io/gengo v0.0.0-20201203183100-97869a43a9d9
# k8s.io/kube-openapi/pkg/generators
/root/go/pkg/mod/k8s.io/[email protected]/pkg/generators/openapi.go:252:11: r.Type undefined (type *"k8s.io/gengo/v2/types".Type has no field or method Type)
make[1]: *** [Makefile:76: bin/openapi-gen] Error 1
make[1]: Leaving directory '/home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/hack/tools'
make: *** [common.mk:49: hack/tools/bin/openapi-gen] Error 2 

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

Signed-off-by: Lennart Jern <[email protected]>
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit f20cc69
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68e8b005f98ddb00088458f1
😎 Deploy Preview https://deploy-preview-2772--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2025
@lentzi90 lentzi90 changed the title Pin kustomize on release-0.12 🌱 Pin kustomize on release-0.12 Oct 10, 2025
Copy link
Contributor

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@lentzi90
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9d003a8 into kubernetes-sigs:main Oct 10, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 10, 2025
@lentzi90 lentzi90 deleted the lentzi90/pin-kustomize-release-0.12 branch October 10, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants