Skip to content

Conversation

@smoshiur1237
Copy link
Contributor

@smoshiur1237 smoshiur1237 commented Oct 20, 2025

Release automation workflow to improve the release work for future.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit cacce9e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/68f89eccd1d70a000819e23b
😎 Deploy Preview https://deploy-preview-2791--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, otherwise this looks good 👍

Signed-off-by: smoshiur1237 <[email protected]>
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@lentzi90
Copy link
Contributor

/cc @bnallapeta
@smoshiur1237 the description still says WIP, can you edit if it is ready now? Feel free to remove hold also.

@smoshiur1237
Copy link
Contributor Author

@lentzi90 thanks for your review. We can take this in. I will update doc in separate PR.

@smoshiur1237
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
Copy link
Contributor

@bnallapeta bnallapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few questions/clarifications:

  1. Will we actually create the releasenotes directory during next release? I think we should create it right now as part of this PR.
  2. Need to clearly document this in release.md as this is a complete change in process.

@smoshiur1237
Copy link
Contributor Author

smoshiur1237 commented Oct 23, 2025

Looks good overall. A few questions/clarifications:

  1. Will we actually create the releasenotes directory during next release? I think we should create it right now as part of this PR.
  2. Need to clearly document this in release.md as this is a complete change in process.
  1. I think releasenote directory will be created on the first release after this PR, if it is not present. We just need to push the chages with a new PR with each release. The newly created md file, for example v0.14.1.md. As a maintainer, we need to add a commit with the change and push the commit. The automation will create tags and push them to upstream.
  2. I will add the documentation to the release.md in separate PR, if it is ok?

@smoshiur1237
Copy link
Contributor Author

/hold
It may need few changes in makefile file. Will update the makefile

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@bnallapeta
Copy link
Contributor

Looks good overall. A few questions/clarifications:

  1. Will we actually create the releasenotes directory during next release? I think we should create it right now as part of this PR.
  2. Need to clearly document this in release.md as this is a complete change in process.
  1. Release note will be created and saved in separate folder named releasenotes and it will add the newly created md file, for example v0.14.1.md file. As a maintainer, you need to add a commit with the change and push the commit. The automation will create tags and push them to upstream.
  2. I will add the documentation to the release.md in separate PR, if it is ok?
  1. So, for the first time, someone needs to create the folder and then add the file. Can we not create the folder right now and add a readme.md with basic info and refine it later in a separate PR? (maybe a .gitkeep too)
  2. I guess its alright, since we don't have any releases soon. But please prioritize that soon.

@smoshiur1237
Copy link
Contributor Author

Looks good overall. A few questions/clarifications:

  1. Will we actually create the releasenotes directory during next release? I think we should create it right now as part of this PR.
  2. Need to clearly document this in release.md as this is a complete change in process.
  1. Release note will be created and saved in separate folder named releasenotes and it will add the newly created md file, for example v0.14.1.md file. As a maintainer, you need to add a commit with the change and push the commit. The automation will create tags and push them to upstream.
  2. I will add the documentation to the release.md in separate PR, if it is ok?
  1. So, for the first time, someone needs to create the folder and then add the file. Can we not create the folder right now and add a readme.md with basic info and refine it later in a separate PR? (maybe a .gitkeep too)
  2. I guess its alright, since we don't have any releases soon. But please prioritize that soon.
  1. I am calling in the makefile with the following which is added under make release : generate-release-notes: $(RELEASE_NOTES_DIR) $(RELEASE_NOTES), which will check if the directory is present or not. So it is not needed to create the folder manually. I think that should be ok.
  2. yes I will add all necessary instructions to complete this.

@lentzi90
Copy link
Contributor

Folder is fine to add with the first release notes, when we make the next release.
Doc update is needed and can be done separately (but please sooner rather than later).

@smoshiur1237
Copy link
Contributor Author

I have checked the makeFile, It looks ok
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@lentzi90
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5584da2 into kubernetes-sigs:main Oct 24, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Oct 24, 2025
@lentzi90 lentzi90 deleted the release-automation branch October 24, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants