-
Notifications
You must be signed in to change notification settings - Fork 282
🌱Release automation workflow #2791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0e7b24c to
0d4a3e1
Compare
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, otherwise this looks good 👍
Signed-off-by: smoshiur1237 <[email protected]>
0d4a3e1 to
cacce9e
Compare
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @bnallapeta |
|
@lentzi90 thanks for your review. We can take this in. I will update doc in separate PR. |
|
/unhold |
bnallapeta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A few questions/clarifications:
- Will we actually create the releasenotes directory during next release? I think we should create it right now as part of this PR.
- Need to clearly document this in release.md as this is a complete change in process.
|
|
/hold |
|
|
|
Folder is fine to add with the first release notes, when we make the next release. |
|
I have checked the makeFile, It looks ok |
|
/lgtm |
Release automation workflow to improve the release work for future.