-
Notifications
You must be signed in to change notification settings - Fork 282
🌱 Set osc lb status when default networks are used #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @nikParasyr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
45bbe5a to
f2d47bb
Compare
|
/ok-to-test |
When apiServerLoadbalancer network is undefined set the apiServerLoadbalancer network status based on the cluster defaults
f2d47bb to
222b50b
Compare
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold cancel
Thanks for the fix!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smoshiur1237
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Currently when a user doesn't define
openStackCluster.Spec.APIServerLoadBalancer.Networkthe status are empty as shown below.Instead of empty, explicitly populate the status using the openStackCluster.Status.Network information
Special notes for your reviewer:
seedling, let me know if it falls under a different categoryTODOs:
/hold