Skip to content

Conversation

@okozachenko1203
Copy link
Contributor

@okozachenko1203 okozachenko1203 commented Oct 29, 2025

What this PR does / why we need it:
Follow-up to: kubernetes-sigs/cluster-api#11889
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit dd809f5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6902aa15a4c0410008d8afa8
😎 Deploy Preview https://deploy-preview-2810--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @okozachenko1203. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@okozachenko1203 okozachenko1203 changed the title feat: add CRDMigrator ✨ Implement CRD migration Oct 29, 2025
@okozachenko1203
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@okozachenko1203: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Contributor

Can you explain what this does and why it is needed?
I thought CRD migration was already implemented in clusterctl, so why now this?

@okozachenko1203
Copy link
Contributor Author

okozachenko1203 commented Oct 29, 2025

Can you explain what this does and why it is needed? I thought CRD migration was already implemented in clusterctl, so why now this?

sure, here are references.

kubernetes-sigs/cluster-api#11889
kubernetes-sigs/cluster-api#11894

@lentzi90
Copy link
Contributor

Thank you! Now I understand!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
@okozachenko1203
Copy link
Contributor Author

/retest

Signed-off-by: okozachenko1203 <[email protected]>
@okozachenko1203
Copy link
Contributor Author

/retest

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@lentzi90
Copy link
Contributor

/cc @smoshiur1237
@adilGhaffarDev have you seen this? We should do the same in CAPM3 also!

@adilGhaffarDev
Copy link

@adilGhaffarDev have you seen this? We should do the same in CAPM3 also!
Yes, I will add this on Capm3 side.

@smoshiur1237
Copy link
Contributor

smoshiur1237 commented Nov 6, 2025

Thanks for this. It looks good to me but I would request to add details in the PR descriptions. Then remove the hold please.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@lentzi90
Copy link
Contributor

lentzi90 commented Nov 7, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 33d80a2 into kubernetes-sigs:main Nov 7, 2025
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants