🌱Add yamlling workflow to check yaml files in pull request #2845
Conversation
Signed-off-by: smoshiur1237 <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lentzi90
left a comment
lentzi90
left a comment
There was a problem hiding this comment.
/approve
It is better than nothing so I don't see a reason to block. My only remaining concern is what version of yamllint this is using, considering that the action has not been updated in 3 years.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I have found the following line for yamllint version in repo: |
|
Yeah the question is if the action is using the latest version of yamllint that was available in 2022 when it was built. I am not sure. Anyway I think this is better than nothing as I said. |
3 participants
This would be an interesting workflow to check on new pull request YAML files. This will be a basic check and I will add more improvement on linter check in separate PRs such as k8s way of indentation, check on snipped yaml code in md files.