-
Notifications
You must be signed in to change notification settings - Fork 284
🐛 Update CAPI contract mapping on CRDs #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🐛 Update CAPI contract mapping on CRDs #2875
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
5c0e29b to
8dd7291
Compare
|
looks good in general. Will add the label once tests are fixed. |
|
ah, I think more files are updated than the last time I checked. I will re-review it once tests pass. |
|
Yeah I am testing a few things. There is something making the e2e tests fail (no Machines are created) when I update the labels. Need to debug a bit. |
Signed-off-by: Lennart Jern <[email protected]>
8dd7291 to
fd33296
Compare
Signed-off-by: Lennart Jern <[email protected]>
|
@lentzi90: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Slack discussion for reference: https://kubernetes.slack.com/archives/C8TSNPY4T/p1764932889047829 Now the question is, what to do with v0.13. We already did two releases advertising v1beta2 and things seems to be working, But in fact we are not fully implementing that contract. Should we fix the 0.13 release by reverting the contract change? Should we keep the inconsistency and quickly start working on a new API version to introduce in v0.14? |
What this PR does / why we need it:
I think we should have updated this already with v0.13.0 but for some reason it slipped through.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold