Skip to content

Conversation

@lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Dec 2, 2025

What this PR does / why we need it:

I think we should have updated this already with v0.13.0 but for some reason it slipped through.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025
@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 768cca0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/6932953a81b6d200080e4c3b
😎 Deploy Preview https://deploy-preview-2875--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2025
@smoshiur1237
Copy link
Contributor

/retest

@lentzi90 lentzi90 force-pushed the lentzi90/capi-contract-mapping branch from 5c0e29b to 8dd7291 Compare December 4, 2025 12:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2025
@bnallapeta
Copy link
Contributor

looks good in general. Will add the label once tests are fixed.

@bnallapeta
Copy link
Contributor

ah, I think more files are updated than the last time I checked. I will re-review it once tests pass.

@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 4, 2025

Yeah I am testing a few things. There is something making the e2e tests fail (no Machines are created) when I update the labels. Need to debug a bit.

@lentzi90 lentzi90 force-pushed the lentzi90/capi-contract-mapping branch from 8dd7291 to fd33296 Compare December 5, 2025 06:30
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

@lentzi90: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 768cca0 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lentzi90
Copy link
Contributor Author

lentzi90 commented Dec 5, 2025

Slack discussion for reference: https://kubernetes.slack.com/archives/C8TSNPY4T/p1764932889047829
My understanding is that it currently works on main because CAPI reads the label and sees v1beta1. It then uses v1beta1 contract even though we put v1beta2 in the metadata.
We won't be able to update the label until we properly support v1beta2 by actually doing breaking changes to the API and introducing a new API version.

Now the question is, what to do with v0.13. We already did two releases advertising v1beta2 and things seems to be working, But in fact we are not fully implementing that contract. Should we fix the 0.13 release by reverting the contract change? Should we keep the inconsistency and quickly start working on a new API version to introduce in v0.14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

4 participants