-
Notifications
You must be signed in to change notification settings - Fork 284
🌱Add new config to pr-link check #2876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: smoshiur1237 <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/cc @bnallapeta |
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other I understand, but why --insecure. Do we have links to sites with broken TLS? I am thinking that we should probably check if we link to such sites.
Actually I have seen issues in other projects where the links are correct but it was giving error in link check with broken TLS.. That's why I am thinking to add it here for future check |
|
If you don't want this insecure tag. I am also ok, not to add it here. Just let me know @lentzi90 |
lentzi90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. The issue is that lychtee can get TLS issues even when browsers work well.
So I am fine with this.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Adding new config for link check on PRs.