-
Notifications
You must be signed in to change notification settings - Fork 284
✨ Add support for autoscaling to/from 0 #2880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Extend OpenStackMachineTemplate.status api with required
field for autoscaling from zero.
Note: Cpu architecture is not added as there are no standardized
settings on openstack where we can retrieve this info
Add OSMT controller behind a feature flag with basic skeleton
Add logic to OpenStackMachineTemplate controller to populate status with: - capacity related information taken from the flavor and rootVolume of the osmt - operatingSystem info taken from the image of the osmt
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @nikParasyr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add documentation for the `AutoScaleFromZero` feature flag
48805c7 to
127b99f
Compare
What this PR does / why we need it:
Add support for autoscaling to/from 0. To do this:
Which issue(s) this PR fixes:
Fixes #1328
Special notes for your reviewer:
I'm currently not adding support for:
architectureattribute but im not sure whether this should be used => I'd prefer to leave this out of this PR and see if users need/require this.TODOs:
/hold