Skip to content

Conversation

@nikParasyr
Copy link
Contributor

What this PR does / why we need it:
Add support for autoscaling to/from 0. To do this:

  • Follow the contract for doing this as documented here
  • Add a new controller to patch OpenStackMachineTemplate.Status accordingly
  • Add the feature behind a feature flag

Which issue(s) this PR fixes:
Fixes #1328

Special notes for your reviewer:
I'm currently not adding support for:

  1. Architecture info: Could not find a standardized flavor extra_spec for this one. There are some traits/resource specific ones but they seem to be for when ironic is used. Images can have an architecture attribute but im not sure whether this should be used => I'd prefer to leave this out of this PR and see if users need/require this.
  2. GPU info: Again couldn't find the standardized extra_spec for this. I would also need to check what type of info autoscaler expects ( just vendor info or even gpu model info etc ) => I'd prefer to leave this out of this PR and see if users need/require this.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests
    • adds e2e tests

/hold

Extend OpenStackMachineTemplate.status api with required
field for autoscaling from zero.
Note: Cpu architecture is not added as there are no standardized
      settings on openstack where we can retrieve this info
Add OSMT controller behind a feature flag with basic
skeleton
Add logic to OpenStackMachineTemplate controller to populate
status with:
- capacity related information taken from the flavor and rootVolume
  of the osmt
- operatingSystem info taken from the image of the osmt
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 127b99f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/693195e1f08d7c0008af606a
😎 Deploy Preview https://deploy-preview-2880--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nikParasyr. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Add documentation for the `AutoScaleFromZero` feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Autoscaling to zero

2 participants