Skip to content

🌱 Start using 1.34 for CI latest on main #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

🌱 Start using 1.34 for CI latest on main #3438

merged 1 commit into from
Apr 25, 2025

Conversation

@fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Apr 24, 2025

/hold for CI

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2025
@fabriziopandini fabriziopandini mentioned this pull request Apr 24, 2025
Merged
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Apr 24, 2025

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Apr 24, 2025

All tests both on PR and on mirror PR are green
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
neolit123
neolit123 reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 25, 2025

LGTM label has been added.

Git tree hash: f9005ffd2d0e3e191749a6a526df0992c522b89f

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc4ec08 into kubernetes-sigs:main Apr 25, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Apr 25, 2025
This was referenced Aug 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@yastij yastij Awaiting requested review from yastij

1 more reviewer

@neolit123 neolit123 neolit123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@neolit123 neolit123

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.14

Development

Successfully merging this pull request may close these issues.

3 participants

@fabriziopandini @k8s-ci-robot @neolit123