Skip to content

Conversation

@chrischdi
Copy link
Member

What this PR does / why we need it:

The old printercolumn did never work because it never was a list, it was always an object.

Fixes #3362

New output uses .spec.controlPlaneEndpoint.host as other providers also do (e.g. CAPZ, CAPO).

CAPA diverges: it has some instances using .spec.controlPlaneEndpoint.host (ManagedAWSCluster, RosaAWSCluster), others .spec.controlPlaneEndpoint.

This PR renders out as e.g.:

❯ kubectl get vspherecluster -o wide
NAME   READY   SERVER   CONTROLPLANEENDPOINT   AGE
foo                     1.2.3.4                18m

An alternative would be to use .spec.controlPlaneEndpoint which would result in json output:

❯ kubectl get vspherecluster -o wide
NAME   READY   SERVER   CONTROLPLANEENDPOINT             AGE
foo                     {"host":"1.2.3.4","port":8443}   19m

Combining host and port would require CEL in additional print columns which needs kubernetes/enhancements#4595 first and in a k8s version which is the lowest supported kubernetes version for the management cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2025
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: addfa75b1174639eaf3c921f312ef76c799a53ff

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@chrischdi
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f9a2173 into kubernetes-sigs:main Jun 4, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect ControlPlaneEndpoint printer column

3 participants