✨ Add kube-api-linter #3560
Merged
✨ Add kube-api-linter #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Member
Author
|
/assign @zhanggbj @chrischdi @DanielXiao Let me know if you have any questions about this PR :) (We're going to use it for #3530) |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 14a239321736fa48cd6716eb903753c04713c029
|
Member
Author
|
Thx! Merging already, will finalize the KAL setup once Fabrizio is back and when we enable KAL in CI /approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the kube-api-linter. The config is heavily inspired by the config in core Cluster API: https://github.com/kubernetes-sigs/cluster-api/blob/main/.golangci-kal.yml
For now KAL is not enabled in CI, we will do that once we can use a version from KAL main again (currently we are using a branch from Joel).
Note: The linter is configured to only lint on the delta from main for now
The linter can be used by:
make lint-apiWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #