Skip to content

🌱 Remove mirror prow handling from scripts #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

🌱 Remove mirror prow handling from scripts #3578

merged 1 commit into from
Aug 19, 2025

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from MaxRink August 18, 2025 17:32
@sbueringer
Copy link
Member Author

/assign @chrischdi @zhanggbj

@k8s-ci-robot k8s-ci-robot requested a review from yastij August 18, 2025 17:32
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 18, 2025
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-33-1-34-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-33-1-34-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

/test pull-cluster-api-provider-vsphere-test-main

/test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-vsphere-apidiff-main

/test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-vsphere-apidiff-main

pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

pull-cluster-api-provider-vsphere-test-main

pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-33-1-34-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-33-1-34-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member Author

Have to look into the test failure

@sbueringer sbueringer force-pushed the pr-cleanup-mirror-prow branch from 14294e5 to a36f5df Compare August 19, 2025 08:20
@sbueringer
Copy link
Member Author

sbueringer commented Aug 19, 2025 •
edited
Loading

Seems okay, just an IP showing up later. Let's see if that occurs more often

This has definitely nothing to do with this PR

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 19, 2025 •
edited
Loading

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-e2e-supervisor-main 14294e5 link true /test pull-cluster-api-provider-vsphere-e2e-supervisor-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

chrischdi
chrischdi reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit: we should also delete:

test/e2e/config/config-overrides-mirror-prow.yaml

@chrischdi
Copy link
Member

/retest

@sbueringer sbueringer force-pushed the pr-cleanup-mirror-prow branch from a36f5df to 3f5a88f Compare August 19, 2025 09:46
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2025
chrischdi
chrischdi reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a550f7b6c764ce7d5b18aca58f030a739d940ae

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit f8ae190 into kubernetes-sigs:main Aug 19, 2025
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Aug 19, 2025
@sbueringer sbueringer deleted the pr-cleanup-mirror-prow branch August 19, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi chrischdi left review comments

@MaxRink MaxRink Awaiting requested review from MaxRink

@yastij yastij Awaiting requested review from yastij

Assignees

@chrischdi chrischdi

@zhanggbj zhanggbj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.15

Development

Successfully merging this pull request may close these issues.

4 participants

@sbueringer @k8s-ci-robot @chrischdi @zhanggbj