Skip to content

✨ Add operating system and architecture information to VSphereMachineTemplate status #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 3 commits into from
Feb 3, 2026
Merged

✨ Add operating system and architecture information to VSphereMachineTemplate status #3788

k8s-ci-robot merged 3 commits into from
Feb 3, 2026
+842 −18

Conversation

@zhouke1991
Copy link
Contributor

@zhouke1991 zhouke1991 commented Jan 22, 2026 •
edited
Loading

What this PR does / why we need it:
Retrieve the OS and Arch information from the ClusterVirtualMachineImage resource and expose them in the VsphereMachineTemplate.Statues. Then the cluster-autoscaler can automatically consume it in the scaling from zero scenario.

  1. ClusterVirtualMachineImage (VM Operator Resource), referenced by the imageName in VsphereMachineTemplate
apiVersion: vmoperator.vmware.com/v1alpha2
kind: ClusterVirtualMachineImage
metadata:
  name: ubuntu-2204-kube-v1.28.0
status:
  name: ubuntu-2204-kube-v1.28.0
  vmwareSystemProperties:
    - key: vmware-system.tkr.os-type
      value: linux
    - key: vmware-system.tkr.os-arch
      value: amd64
  productInfo:
    fullVersion: "22.04"
  osInfo:
    type: linux
  1. VSphereMachineTemplate (After - With Status Populated by Controller)
apiVersion: vmware.infrastructure.cluster.x-k8s.io/v1beta2
kind: VSphereMachineTemplate
metadata:
  name: worker-template
  namespace: default
spec:
  template:
    spec:
      className: best-effort-small
      imageName: ubuntu-2204-kube-v1.28.0
      storageClass: wcpglobal-storage-profile
status:
  capacity:
    cpu: "2"
    memory: "4Gi"
  nodeInfo:
    architecture: amd64
    operatingSystem: linux

Supported Values

Operating Systems:

  • linux
  • windows

Architectures:

  • amd64
  • arm64
  • s390x
  • ppc64le

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3780

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vrabbi January 22, 2026 08:40
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 22, 2026

Welcome @zhouke1991!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 22, 2026

Hi @zhouke1991. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2026
@zhouke1991 zhouke1991 force-pushed the topic/platform-autoaware branch from 01c0785 to 590fb7f Compare January 22, 2026 09:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2026
@zhouke1991 zhouke1991 changed the title Add operating system and architecture information to VSphereMachineTemplate status ✨ Add operating system and architecture information to VSphereMachineTemplate status Jan 22, 2026
@zhouke1991 zhouke1991 force-pushed the topic/platform-autoaware branch from 590fb7f to 13e016c Compare January 22, 2026 10:33
@sbueringer
Copy link
Member

sbueringer commented Jan 22, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2026
@sbueringer
Copy link
Member

sbueringer commented Jan 22, 2026

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@zhouke1991
Copy link
Contributor Author

zhouke1991 commented Jan 23, 2026

Code to consume the nodeInfo in cluster-autoscaler: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go#L395-L396

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@zhouke1991 zhouke1991 force-pushed the topic/platform-autoaware branch from 13e016c to ce768dd Compare January 28, 2026 10:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2026
@zhouke1991
Copy link
Contributor Author

zhouke1991 commented Jan 28, 2026

/retest

@sbueringer
Copy link
Member

sbueringer commented Jan 28, 2026

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

sbueringer commented Jan 28, 2026

/retest

sbueringer
sbueringer reviewed Jan 28, 2026
View reviewed changes
@zhouke1991 zhouke1991 force-pushed the topic/platform-autoaware branch from 20a5ad3 to e6dca59 Compare February 3, 2026 08:16
sbueringer
sbueringer reviewed Feb 3, 2026
View reviewed changes
@sbueringer
Copy link
Member

sbueringer commented Feb 3, 2026

/test ?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

@sbueringer: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-35-1-36-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-35-1-36-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-v1-8-6-v1alpha2-main

/test pull-cluster-api-provider-vsphere-e2e-supervisor-v1-9-0-v1alpha2-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

/test pull-cluster-api-provider-vsphere-test-main

/test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-vsphere-apidiff-main

/test pull-cluster-api-provider-vsphere-janitor-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-vsphere-apidiff-main

pull-cluster-api-provider-vsphere-e2e-govmomi-blocking-main

pull-cluster-api-provider-vsphere-e2e-supervisor-blocking-main

pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

pull-cluster-api-provider-vsphere-test-main

pull-cluster-api-provider-vsphere-verify-main
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

sbueringer commented Feb 3, 2026

/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-main
/test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-35-1-36-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main
/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@sbueringer
Copy link
Member

sbueringer commented Feb 3, 2026

Thx!

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

LGTM label has been added.

DetailsGit tree hash: 75c56b2d6264d31df4e46405d15d7e424ccb58f7

@zhouke1991
Copy link
Contributor Author

zhouke1991 commented Feb 3, 2026

/retest

fabriziopandini
fabriziopandini reviewed Feb 3, 2026
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit 7706169 into kubernetes-sigs:main Feb 3, 2026
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

Implement OS and Architecture Awareness for autoscaling from zero

4 participants

@zhouke1991 @k8s-ci-robot @sbueringer @fabriziopandini