🌱 Add Unit tests for reconcileDelete by arshadd-b · Pull Request #11636 · kubernetes-sigs/cluster-api

arshadd-b · 2025-01-06T03:39:43Z

🌱

What this PR does / why we need it:
ThIs improves test coverage of Machine Controller reconcileDelete

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #11626

k8s-ci-robot · 2025-01-06T03:39:51Z

This PR is currently missing an area label, which is used to identify the modified component when generating release notes.

Area labels can be added by org members by writing /area ${COMPONENT} in a comment

Please see the labels list for possible areas.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-01-06T03:39:52Z

Welcome @arshadd-b!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-01-06T03:39:53Z

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Karthik-K-N · 2025-01-06T05:04:04Z

/ok-to-test

arshadd-b · 2025-01-06T05:45:44Z

Hi @sbueringer
I have tried to cover the entire function reconcileDelete
but these are pending blocks and all are negative test cases

could you please guide me how i can cover these cases as well ?
Thanks

arshadd-b · 2025-01-06T07:29:25Z

/retest

internal/controllers/machine/machine_controller_test.go

enxebre · 2025-01-07T11:22:43Z

internal/controllers/machine/machine_controller_test.go

+	}
+}
+
+func TestNodeDeletionWithPreDrainHook(t *testing.T) {


why isn't this one a test case of the above?

In this testCase, need some custom object to be passed here in the client
https://github.com/kubernetes-sigs/cluster-api/pull/11636/files#diff-eca451c4058d015075de4b1e9713d6154e1d50f7d4595df4218d87fb0163bc20R3858

k8s-ci-robot · 2025-01-07T13:13:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alexander-demicev · 2025-01-09T16:35:40Z

internal/controllers/machine/machine_controller_test.go

+		},
+	}
+
+	cpmachine1 := &clusterv1.Machine{


I might be missing something, is cpmachine1 used in the test?

yeah, Actually it is used here while creating Fake client
https://github.com/kubernetes-sigs/cluster-api/pull/11636/files#diff-eca451c4058d015075de4b1e9713d6154e1d50f7d4595df4218d87fb0163bc20R3689

arshadd-b · 2025-01-27T05:45:59Z

Hi @enxebre @alexander-demicev I have addressed all the review comments, could you please a look
Thanks

k8s-triage-robot · 2025-04-27T06:11:45Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-05-27T07:05:57Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-06-26T07:18:48Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-06-26T07:18:54Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sbueringer · 2025-06-26T08:20:39Z

/reopen
/remove-lifecycle rotten

k8s-ci-robot · 2025-06-26T08:20:46Z

@sbueringer: Reopened this PR.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

arshadd-b · 2025-06-26T10:00:18Z

/retest

k8s-triage-robot · 2025-10-19T14:48:52Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-11-18T14:53:13Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-12-18T15:52:04Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-12-18T15:52:11Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fabriziopandini · 2026-02-04T13:35:15Z

/re-open

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2025

k8s-ci-robot requested a review from enxebre January 6, 2025 03:39

k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Jan 6, 2025

k8s-ci-robot requested a review from sbueringer January 6, 2025 03:39

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 6, 2025

arshadd-b changed the title ~~Add Unit tests for reconcileDelete~~ (:seedling:) Add Unit tests for reconcileDelete Jan 6, 2025

arshadd-b changed the title ~~(:seedling:) Add Unit tests for reconcileDelete~~ 🌱 Add Unit tests for reconcileDelete Jan 6, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2025

arshadd-b force-pushed the reconcileDelete-ut branch from 9a4081f to fc4ae67 Compare January 6, 2025 05:41

enxebre reviewed Jan 7, 2025

View reviewed changes

internal/controllers/machine/machine_controller_test.go Outdated Show resolved Hide resolved

enxebre reviewed Jan 7, 2025

View reviewed changes

internal/controllers/machine/machine_controller_test.go Outdated Show resolved Hide resolved

enxebre reviewed Jan 7, 2025

View reviewed changes

arshadd-b force-pushed the reconcileDelete-ut branch 2 times, most recently from fe1a466 to cb8e89c Compare January 8, 2025 04:31

alexander-demicev reviewed Jan 9, 2025

View reviewed changes

arshadd-b requested review from alexander-demicev and enxebre January 27, 2025 05:46

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2025

k8s-ci-robot closed this Jun 26, 2025

k8s-ci-robot reopened this Jun 26, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 26, 2025

arshadd-b force-pushed the reconcileDelete-ut branch from cb8e89c to 013a575 Compare July 21, 2025 12:54

arshadd-b mentioned this pull request Sep 12, 2025

REQUEST: New membership for arshadd-b kubernetes/org#5835

Closed

11 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 18, 2025

k8s-ci-robot closed this Dec 18, 2025

fabriziopandini removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 4, 2026

sbueringer reopened this Feb 4, 2026

arshadd-b added 2 commits February 9, 2026 09:25

Add Unit tests for reconcileDelete

c84dca9

address review comments

9caf4c3

arshadd-b force-pushed the reconcileDelete-ut branch from 22c7eb3 to 9caf4c3 Compare February 9, 2026 03:55

fix failing tests

f76c4f2

Comments

Conversation

arshadd-b commented Jan 6, 2025 • edited by sbueringer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 6, 2025

Uh oh!

k8s-ci-robot commented Jan 6, 2025

Uh oh!

k8s-ci-robot commented Jan 6, 2025

Uh oh!

Karthik-K-N commented Jan 6, 2025

Uh oh!

arshadd-b commented Jan 6, 2025

Uh oh!

arshadd-b commented Jan 6, 2025

Uh oh!

Uh oh!

Uh oh!

enxebre Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 7, 2025

Uh oh!

alexander-demicev Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-triage-robot commented Apr 27, 2025

Uh oh!

k8s-triage-robot commented May 27, 2025

Uh oh!

k8s-triage-robot commented Jun 26, 2025

Uh oh!

k8s-ci-robot commented Jun 26, 2025

Uh oh!

sbueringer commented Jun 26, 2025

Uh oh!

k8s-ci-robot commented Jun 26, 2025

Uh oh!

arshadd-b commented Jun 26, 2025

Uh oh!

k8s-triage-robot commented Oct 19, 2025

Uh oh!

k8s-triage-robot commented Nov 18, 2025

Uh oh!

k8s-triage-robot commented Dec 18, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

fabriziopandini commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

arshadd-b commented Jan 6, 2025 •

edited by sbueringer

Loading

arshadd-b Jan 7, 2025 •

edited

Loading

arshadd-b commented Jan 27, 2025 •

edited

Loading